Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only clone git repository once at the beginning on the run #109

Merged
merged 28 commits into from
Nov 2, 2020
Merged

Only clone git repository once at the beginning on the run #109

merged 28 commits into from
Nov 2, 2020

Conversation

olblak
Copy link
Member

@olblak olblak commented Oct 29, 2020 •
edited

This PR refactor the main engine by

  • Adding a new stage named "prepare" where we can clone needed git repositories only once.
  • Exports the GitHub parameter Directory in order to define custom directories from updatecli.
  • Simplifies the condition spec interface by moving the logic to the package which satisfies the interface. Now the condition interface requires two interface method condition(version) and conditionFromSCM(version, scm)
  • Simplifies the target spec interface by moving the logic to the package which satisfies the interface. Now the target interface requires two interface method target and targetFromSCM
  • Reorganise code under core and plugins directory
  • Allow git/github to add several files in once

Time:
./bin/updatecli apply --config --values 21,07s user 1,95s system 66% cpu 34,422 total

@olblak
Allow to set github directory
d306b01 
Init git repository in clone function

Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Add a name parameter to config struct
b7de228 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Remove engine logic from root cmd
d7e92cf 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Rename target&condition execute function to run
46fa17d
@olblak
Refactor reports to avoid circular dependency
3240051
@olblak
Only run git clone once
c306776 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak changed the title Only clone git repository once at the beginning on the run [WIP] Only clone git repository once at the beginning on the run Oct 29, 2020
@olblak
Fix regression where we stop save result to report
a5a9872 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Fix regression where we do not set git working dir
5f0cf0f 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Fix regression where we do not set github working dir
6aa30f9 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Refactor Condition interface and split scm and none scm condition
0220716 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Only conditions in reports if one set
589c2c7 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Remove unneeded variable assignement
c568030 
Use short variable assignment

Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Refactor target interface
f8c686b 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Remove debug message
f16db5b 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Git commit can commit multiple files at the same time using the same …
2c5657a 
…message
@olblak
Split docker package into several files
327a5e2 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Split yaml package into several files
99645f7 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Split maven package into several files
12c6184 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Split helm package into several files
5476ac6 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Split github package into several files
a01d1d7 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Reorganise code under core and plugins directory
6ed8193 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Add prepare subcommand
5a9f538 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Git clone use print from buffer instead of fmt
dbe5796 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Remove debugging string
9cd438e 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Run initial git clone in goroutines
1e68675 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Remove unneeded comments
95e37e8 
Add configuration file name with an issue

Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Polish documentation
8da6723
@olblak
Update README
cabc5e9 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak changed the title [WIP] Only clone git repository once at the beginning on the run Only clone git repository once at the beginning on the run Nov 2, 2020
@olblak olblak merged commit f3f0137 into master Nov 2, 2020
@olblak olblak added the enhancement New feature or request label Nov 4, 2020
@jetersen
Copy link
Member

jetersen commented Nov 4, 2020

🚀 Great job on this major refactoring. Nice to see those performance gains!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olblak @jetersen