Fix autodiscovery jsonschema #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename function `GenerateJsonSchema` to `AppendOneOfToJsonSchema` to better describe its meaning * Fix deprecation by replacing ioutil.Writefile to os.Writefile * Add function `AppendMapToJsonSchema` to handle the situation where we need to append properties to an existing object Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest fix the jsonschema generated for the autodiscovery.
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement
As of today, Updatecli codebase, relies on the function
Newto initiate object. it uses a map of plugin to define the behavior and due to that, the invopop/jsonschema requires to implement the interfacefunc (ConfigType) JSONSchema() *jschema.Schemato generate the jsonschema corresponding to the map of plugin. Hence the current pullrequestAnother approach would be to implement a json (un)marshaller for each config that works with plugins. If we get rid of the New function in favor of the unmarshaller approach, then we would also need to implement of yaml.
Based on my initial experimentation, it makes the codebase more difficult to write and maintain