Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Git Tag) target should not fail due to "no updated files" #1127

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Feb 1, 2023

Signed-off-by: Olblak me@olblak.com

Related to #1126

Git tag target shouldn't fail

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the bug Something isn't working label Feb 1, 2023
@olblak olblak changed the title Git Tag targer shouldn't fail Git Tag target shouldn't fail Feb 1, 2023
@olblak olblak added target Related to updatecli target resource-gittag Resource of kind Git Tag labels Feb 1, 2023
@olblak olblak added this to the 0.44.0 milestone Feb 1, 2023
@olblak olblak merged commit fd250ef into updatecli:main Feb 1, 2023
@dduportal dduportal changed the title Git Tag target shouldn't fail fix(Git Tag) target should not fail due to "no updated files" Feb 1, 2023
@dduportal
Copy link
Contributor

@olblak I've updated the PR title trying to improve the changelog: WDYT?

@olblak
Copy link
Member Author

olblak commented Feb 1, 2023

@olblak I've updated the PR title trying to improve the changelog: WDYT?

Thank you I like it more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resource-gittag Resource of kind Git Tag target Related to updatecli target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants