Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shell changedif workdir #1155

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

olblak
Copy link
Member

@olblak olblak commented Feb 13, 2023

Signed-off-by: Olblak me@olblak.com

Fix a bug where precommand and postcommand do not use the same workingDir than the main command

Test

/

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added bug Something isn't working resource-shell Resource of kind Shell labels Feb 13, 2023
@olblak olblak enabled auto-merge (squash) February 13, 2023 17:38
@ghost
Copy link

ghost commented Feb 13, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@olblak olblak merged commit fcd4378 into updatecli:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resource-shell Resource of kind Shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant