upload assets on published release #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what you use the |
jetersen
commented
Nov 10, 2020
|
|
||
| BINARY="$BASENAME.$GOOS.$GOARCH" | ||
| BINARY_DIRECTORY="./bin/" | ||
| BINARY_DIRECTORY="./bin" |
There was a problem hiding this comment.
The path had double slashes
see line 23 and 30.
jetersen
commented
Nov 10, 2020
|
We have access to all this event data: https://docs.github.com/en/free-pro-team@latest/developers/webhooks-and-events/webhook-events-and-payloads#release |
Co-authored-by: Joseph Petersen <josephp90@gmail.com>
olblak
reviewed
Nov 10, 2020
| - name: Build updateCli | ||
| run: | | ||
| touch updateCli.env | ||
| make build.all |
There was a problem hiding this comment.
Does the ubuntu-latest environment has golang installed?
olblak
approved these changes
Nov 10, 2020
|
Thanks, awesome, I wanted to work on this for a while
I use it source local environment variables, it's not needed anymore with your PR, I'll remove it |
|
Your very welcome! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted the last two releases did not come with all the assets, so created this to upload them all on publish.