Allow to open GitHub pullrequest on parent repository #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frelon
force-pushed
the
github-upstream
branch
from
fbca034
to
5834d6e
Compare
|
Nice one. @frelon, did you try to update an existing pullrequest created by the updatecli pipeline? Because I have situation where the pullrequest can evolve and I would like to update the title, for example such on olblak/kubernetes-marketplace#10 where the title display the version bump |
If upstream is set to true in the spec, the PR will be opened against the upstream of the repository specified in scm. Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
frelon
force-pushed
the
github-upstream
branch
from
5834d6e
to
5aadb7e
Compare
Only updating labels of existing PR:s if labels are specified, otherwise we will receive a permission denied for updating PR:s, even though no labels are added. Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
|
@olblak I tried it initially, but got |
Awesome, and it definitely seems cleaner |
olblak
reviewed
Feb 27, 2023
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
frelon
force-pushed
the
github-upstream
branch
from
0a1eebc
to
1a184e3
Compare
olblak
approved these changes
Feb 27, 2023
olblak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1096
This PR enables updatecli to open new GitHub pull-requests against parent repositories.
Since it is implied the user will not have write-access upstream we will skip setting labels/assignees/etc if not specified in the spec.
Example yaml:
This pushes changes to
elemental-ci/elemental-cliand opens the PR against the upstreamrancher/elemental-clias expected!