Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle XML file path #1212

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Correctly handle XML file path #1212

merged 1 commit into from
Mar 8, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Mar 8, 2023

This pullrequest correctly handle XML file path according the different scenarios, relative path, path from scm, etc.

Fix #1210

Test

To test this pull request, you can run the following commands:

go build -o bin/updatecli . 
./bin/updatecli apply --config e2e/updatecli.d/success.d/xml.yaml --clean=true --push=false
cd pkg/plugins/resources/xml
go test .

Additional Information

Tradeoff

Potential improvement

  • The source function received a workdir set to the current directory by default. This means we need additional code for each plugin to check the value of that workdir param. This behavior is confusing and should be handled in the "core" codebase

Fix xml value

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added resource-xml Modify resource of type xml bug Something isn't working labels Mar 8, 2023
@olblak olblak merged commit 43935e1 into updatecli:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resource-xml Modify resource of type xml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML target fail to find file when using scmid
1 participant