Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gitlab support #1219

Merged
merged 23 commits into from
Mar 13, 2023
Merged

Add Gitlab support #1219

merged 23 commits into from
Mar 13, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Mar 11, 2023

Fix #738

This pullrequest add the following items

  • Gitlab scm support
  • gitlab/mergerequest action
  • Add gitlab resource to manipulate
    • branch
    • tag
    • release

Some effort is still need to fix the tests and to add e2e tests.
I'll probably need to mirror github.com/updatecli-test to gitlab

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak
Copy link
Member Author

olblak commented Mar 12, 2023

During my tests, the only issue I got so far is some pagination issue when retrieve git tag from Gitlab api

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the enhancement New feature or request label Mar 12, 2023
olblak and others added 6 commits March 12, 2023 20:55
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak
Copy link
Member Author

olblak commented Mar 13, 2023

I just tested mergerequest and it works as expected \o/

@olblak olblak enabled auto-merge (squash) March 13, 2023 12:24
@olblak olblak merged commit 1b4c4ba into updatecli:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scm-gitlab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add SCM gitlab support
1 participant