Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly build updatecli from Dockerfile #126

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Correctly build updatecli from Dockerfile #126

merged 1 commit into from
Nov 22, 2020

Conversation

olblak
Copy link
Member

@olblak olblak commented Nov 22, 2020

This PR correctly set variable that contains version information like

VERSION

Application:	v0.0.25-7-gb292cf8
Golang     :	1.15.5 linux/amd64
Build Time :	Sun, 22 Nov 2020 13:53:57 +0000

Instead of the current broken situation that return nothing like
docker run olblak/updatecli:v0.0.24 version returns

VERSION


Application:	

Build Time :

Signed-off-by: Olivier Vernin olivier@vernin.me

@olblak
Correctly build updatecli from Dockerfile
af5fb5e 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak merged commit 8aa498f into master Nov 22, 2020
@olblak olblak deleted the Dockerfile_version branch November 22, 2020 14:22
@olblak olblak added the bug Something isn't working label Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@olblak