Refactor source resource to return more metadata #1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1299
Instead of returning a source result as a simple string.
This pullrequest introduces the
result.Source
struct. This new struct allows to save additional information such as the "source" execution description, result, and information retrieved from the source.Any error returned by the function would result the source execution as a failure.
It's up to the source plugin to decide if an empty value should be considered as an error or not.
If an empty value is allowed by a plugin, then we always display a "debug" message.
While some mistake could have slip during the refactor, normally everything should work the same way it used to be
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement