Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor condition resource to return more metadata #1314

Merged
merged 43 commits into from
May 3, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented May 2, 2023

Refactor condition resource

This refactoring includes:

  1. Merging the function Condition and ConditionFromSCM, over time I realized that it didn't make sense to have them separated
  2. Condition stores its result execution in a struct which allows to gather more additional data for building a meaningful report at the end of a pipeline execution
  3. Only use logrus.Infof to describe in one place a specific condition execution, and move everything else to warning, errorf, or debug

Now a condition can result in of the following case:

  • Condition successfull
  • Condition failing without no error
  • Condition failing with an erro

If the condition is failing with no error, then the final result can be changed with the failwhen parameter

Test

You should run as many test as you could

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
olblak added 4 commits May 2, 2023 08:50
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
olblak and others added 9 commits May 2, 2023 10:33
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the skip-changelog Used by release-drafter to ignore pullrequest in changelog label May 3, 2023
@olblak olblak merged commit 8e0920b into updatecli:main May 3, 2023
5 checks passed
@olblak olblak deleted the refactorCondition branch May 3, 2023 12:19
@olblak olblak changed the title Refactor condition result Refactor condition resource to return more metadata May 5, 2023
@olblak olblak removed the skip-changelog Used by release-drafter to ignore pullrequest in changelog label May 5, 2023
@olblak olblak self-assigned this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant