Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More compact footer template in Pullrequest created by Updatecli #1316

Merged
merged 7 commits into from
May 4, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented May 3, 2023

Fix #1308

More compact footer and small rewording like Action triggered by Updatecli > Created by Updatecli

Before:

image

After:

image

Open:
image

Test

N/A

Additional Information

Tradeoff

N/A

Potential improvement

See comment below: #1316 (comment)

Example

Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via Updatecli manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

@lemeurherve
Copy link
Member Author

cc @v1v, WDYT?

@lemeurherve
Copy link
Member Author

If the <table> syntax isn't supported elsewhere than GitHub, I propose this as an alternative with Markdown table:


Updatecli logo Created automatically by Updatecli
Options:

Most of Updatecli configuration is done via Updatecli manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at updatecli/updatecli. If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, or to tell us directly on our chat!

@olblak
Copy link
Member

olblak commented May 3, 2023

Thanks for the pullrequest, I just tested on Gitlab and Gitea and it works great.
I am waiting for @v1v feedback before merging

v1v
v1v previously approved these changes May 4, 2023
Copy link
Contributor

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, I like that and thanks for this! ❤️

Co-authored-by: Hervé Le Meur <52448671+hervelemeur@users.noreply.github.com>
@olblak olblak enabled auto-merge (squash) May 4, 2023 10:11
@olblak olblak merged commit 6d8924c into updatecli:main May 4, 2023
5 checks passed
@lemeurherve lemeurherve deleted the issue1308-less-verbose-footer branch May 4, 2023 10:23
@olblak olblak added the enhancement New feature or request label May 20, 2023
@olblak olblak changed the title chore: more compact footer template More compact footer template in Pullrequest created by Updatecli May 20, 2023
@olblak olblak removed the chore label May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: PR description a bit too verbose
5 participants