Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file path #1322

Merged
merged 2 commits into from
May 4, 2023
Merged

Fix file path #1322

merged 2 commits into from
May 4, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented May 4, 2023 •
edited

Fix #1320

  • Fix regression, correctly set file path used by file plugin
  • Add missing e2e tests for the file resource

Test

To test this pull request, you can run the following commands:

go build -o bin/updatecli .
./bin/updatecli diff --config e2e/updatecli.d/success.d/file/

Additional Information

Tradeoff

Potential improvement

@olblak
Correctly set file path
edd2fb7 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added bug Something isn't working resource-file Resource of kind File labels May 4, 2023
@olblak olblak enabled auto-merge (squash) May 4, 2023 18:27
@olblak olblak merged commit 3e32582 into updatecli:main May 4, 2023
5 checks passed
@olblak olblak deleted the issue/1320 branch May 4, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working resource-file Resource of kind File
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues when using conditions of kind file and 0.49.2-next
1 participant
@olblak