Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spelling #1330

Merged
merged 48 commits into from
May 22, 2023
Merged

fix spelling #1330

merged 48 commits into from
May 22, 2023

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 17, 2023

This PR corrects misspellings identified by the check-spelling action.

Test

The misspellings have been reported at https://github.com/jsoref/updatecli/actions/runs/5002389671#summary-13547422360

The action reports that the changes in this PR would make it relatively happy: https://github.com/jsoref/updatecli/actions/runs/5002389949#summary-13547422914

Additional Information

Tradeoff

  • If there are library consumers and the changes break apis (I tried to avoid this), there could be some pain.
  • A nontrivial number of files have been changed. From my perspective, this is a relatively small set of changes, and it's possible to split them and review them by kind, directory, or incrementally

Potential improvement

jsoref added 30 commits May 17, 2023 06:09
@jsoref
spelling: abstraction
2eb6b43 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: adopters
00a43f1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: already
e680981 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: alreadyexists
d8de6b7 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: assume
413425c 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: branch
8c8f0e5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: central
a80120b 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: deprecation
a02fff3 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: endpoint
f8cb509 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: exclusive
a4f0499 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: filter
db70095 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: future
f6e5f11 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: github
645470f 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: gitlab
0a72596 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: kind
369947a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: literally
d192824 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: manipulate
d15a53d 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: metadata
66834a1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: multiple
c4effe0 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: nominal
9cdd9ed 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: nonexistent
5a658bb 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: passphrase
735964e 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: pipelineid
90dd58a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: pull requests
d743bc0 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: relative
9e8067f 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: repository
ce387cd 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: resource
94a53aa 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: semantic
dbc6d4a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: settings
828f542 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: should
57db6c4 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: unexpected
9a6f799 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: unmarshal
8926cfd 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: updatecli
7bc2c3a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: used
c7fb7d5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: useless
229363f 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: vertices
0e26587 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: wanted
ba6d5cc 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: with
3f1388a 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: yellow
3818681 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
jsoref commented May 17, 2023
View reviewed changes
README.adoc Show resolved Hide resolved
e2e/updatecli.d/success.d/command.yaml Show resolved Hide resolved
e2e/updatecli.d/success.d/gitBranch.yaml Show resolved Hide resolved
e2e/updatecli.d/success.d/gitlab/branch.yaml Show resolved Hide resolved
pkg/core/config/main_test.go Show resolved Hide resolved
pkg/plugins/resources/gitlab/release/main.go Outdated Show resolved Hide resolved
pkg/plugins/resources/gitlab/tag/main.go Show resolved Hide resolved
pkg/plugins/resources/stash/release/main.go Outdated Show resolved Hide resolved
pkg/plugins/scms/github/main.go Show resolved Hide resolved
pkg/plugins/scms/gitlab/main.go Show resolved Hide resolved
@olblak
Copy link
Member

olblak commented May 18, 2023

Thank you very much for finding and fixing typos, especially considering www.updatecli.io is heavily generated from code comments.

I recently integrated https://github.com/crate-ci/typos but it appears you found many others

olblak
olblak reviewed May 20, 2023
View reviewed changes
pkg/core/config/main.go Outdated Show resolved Hide resolved
olblak
olblak previously approved these changes May 20, 2023
View reviewed changes
@jsoref @olblak
Use single word for pullrequests
cdd1c12 
Co-authored-by: Olivier Vernin <olivier@vernin.me>
dduportal
dduportal reviewed May 21, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is really an helpful contribution, many thanks!

I've 3 suggestions (if I'm not mistaken)

pkg/plugins/resources/dockerimage/spec.go Outdated Show resolved Hide resolved
pkg/plugins/resources/gitlab/release/main.go Outdated Show resolved Hide resolved
pkg/plugins/resources/stash/release/main.go Outdated Show resolved Hide resolved
@olblak olblak added the cleanup label May 22, 2023
@olblak olblak changed the title Spelling fix spelling May 22, 2023
@olblak olblak merged commit 4989884 into updatecli:main May 22, 2023
5 checks passed
@olblak
Copy link
Member

olblak commented May 22, 2023

Thanks @jsoref for the pullrequest, that would be awesome if you could also contribute the github workflow that led to this PR

@jsoref jsoref deleted the spelling branch May 22, 2023 11:14
@jsoref jsoref mentioned this pull request May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal left review comments

@olblak olblak olblak left review comments

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsoref @olblak @dduportal