Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yaml plugin regression #1338

Merged
merged 2 commits into from
May 21, 2023
Merged

Fix yaml plugin regression #1338

merged 2 commits into from
May 21, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented May 21, 2023

  • Fix yaml plugin message if executed in dryrun set to false
  • Fix yaml plugin execution result

Test

To test this pull request, you can run the following commands:
`

/

Additional Information

Tradeoff

Potential improvement

@olblak
yaml resource should only use 'should' in dryrun mode
e95c61e 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the bug Something isn't working label May 21, 2023
@olblak olblak enabled auto-merge (squash) May 21, 2023 13:07
@olblak olblak merged commit 26040c5 into updatecli:main May 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@olblak