Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerfile target result in case of success #1368

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Jun 8, 2023

While doing some test with the dockerfile autodiscovery, I noticed a regression in the dockerfile plugin resource.
Where the result is not set if nothing change

TARGETS
========

registry.access.redhat.com/ubi9/ubi
-----------------------------------

**Dry Run enabled**

✔ The line #12, matched by the keyword "FROM" and the matcher "registry.access.redhat.com/ubi9/ubi", is correctly set to "FROM registry.access.redhat.com/ubi9/ubi:9.2-489".
- - 


Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added bug Something isn't working resource-dockerfile Resource of kind Dockerfile labels Jun 8, 2023
@olblak olblak enabled auto-merge (squash) June 8, 2023 06:55
@olblak olblak merged commit 15f135c into updatecli:main Jun 8, 2023
6 checks passed
@dduportal
Copy link
Contributor

Confirmed that this PR fixes the error: we have the error with https://github.com/jenkinsci/docker-ssh-agent/blob/master/updatecli/updatecli.d/git-windows.yml (the GHA checks are red for now, using latest updatecli).

Tried locally, comparing latest updatecli and a build of the upcoming 0.53.0: the problem is gone with 0.53.0.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resource-dockerfile Resource of kind Dockerfile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants