Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versionfilter to maven resource #1375

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

olblak
Copy link
Member

@olblak olblak commented Jun 12, 2023

Fix #1374

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/utils/mavenmetadata
go test
go build -o bin/updatecli . 
./bin/updatecli diff --config e2e/updatecli.d/success.d/maven.yaml

Additional Information

Tradeoff

Potential improvement

I didn't bother adding support for Jenkins considering the time spent on this versus the usage and the benefit :)
I may revisit this decision in the futur

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the enhancement New feature or request label Jun 12, 2023
@olblak olblak added this to the 0.53.0 milestone Jun 12, 2023
@olblak olblak added the resource-mavenrepository Resource of kind Maven Repository label Jun 13, 2023
@olblak olblak merged commit 76cf2be into updatecli:main Jun 13, 2023
6 checks passed
@olblak olblak deleted the issue/1374 branch June 13, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resource-mavenrepository Resource of kind Maven Repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven resource missing versionFilter support
1 participant