Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Maven autodiscovery to override default version filter #1376

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Allow Maven autodiscovery to override default version filter #1376

merged 4 commits into from
Jun 13, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Jun 13, 2023

  • Fix minor xml message
  • Allow Maven autodiscovery to override default version filter

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

@olblak
fix xml success message
6c823b7 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Allow Maven autodiscovery to override default version filter
b8dc3c2 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added resource-mavenrepository Resource of kind Maven Repository autodiscovery All things related to the autodiscovery feature labels Jun 13, 2023
@olblak
use default versionfilter
89e71b1 
Signed-off-by: Olblak <me@olblak.com>
@olblak
fix formatting
79aa227 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak merged commit 09d34f4 into updatecli:main Jun 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
autodiscovery All things related to the autodiscovery feature resource-mavenrepository Resource of kind Maven Repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@olblak