Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml resource can read file from http url #141

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Yaml resource can read file from http url #141

merged 4 commits into from
Jan 22, 2021

Conversation

olblak
Copy link
Member

@olblak olblak commented Jan 22, 2021

This PR refactor the file and yaml resource in order to use the same function to manipulate files.
Yaml now use the same approach than file resource by

  • Deprecating the parameter 'path', that parameter was a mistake since the beginning
  • The parameter 'File' now accepted following URL
    ** https://url, http://, file:// file://

Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak added the enhancement New feature or request label Jan 22, 2021
@olblak olblak merged commit add265a into master Jan 22, 2021
@olblak olblak deleted the yaml branch January 23, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant