Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to merge multiple values/secret files #1447

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Conversation

olblak
Copy link
Member

@olblak olblak commented Aug 4, 2023

  • fix multiple values file specified
  • fix absolute values file path specified

Fix #1403 #1415 #1253

Test

To test this pull request, you can run the following commands:

cd pkg/core/config/
go test

go build -o bin/updatecli .
./bin/updatecli diff --config manifest.yaml --values --values ../tmp/1.yaml --values ./2.yaml --values /tmp/3.yaml

Additional Information

Tradeoff

Potential improvement

* fix multiple values file specified
* fix absolute values file path specified

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the bug Something isn't working label Aug 4, 2023
olblak and others added 5 commits August 4, 2023 13:17
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak
Copy link
Member Author

olblak commented Aug 4, 2023

Tested the PR on windows and both relative and absolute path worked

@olblak olblak merged commit 0b8cddc into updatecli:main Aug 4, 2023
6 checks passed
@olblak olblak deleted the issue/1403 branch August 4, 2023 13:06
@olblak olblak added this to the 0.56.0 milestone Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: multiple values files can be specified
1 participant