-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle non-existing cargo packages #1460
Merged
olblak
merged 5 commits into
updatecli:main
from
loispostula:fix-cargo-package-inexting-package
Aug 10, 2023
Merged
fix: handle non-existing cargo packages #1460
olblak
merged 5 commits into
updatecli:main
from
loispostula:fix-cargo-package-inexting-package
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olblak
previously approved these changes
Aug 10, 2023
olblak
reviewed
Aug 10, 2023
olblak
reviewed
Aug 10, 2023
olblak
reviewed
Aug 10, 2023
lemeurherve
reviewed
Aug 10, 2023
olblak
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I faced the same condition problem for other plugin.
I don't reminder if it is unified but I think it is the right approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1459
Make sure we can handle the cases when a package does not exists
Test
To test this pull request, you can run check the following pipeline file