Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Updatecli manifest/values to use JSON file #1463

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Aug 10, 2023

depends on:

Allow to use JSON, technically speaking json a subset of YAML and therefor fully compatible.
For complex template, I find using json more convenient than yaml as we don't have to deal with tab and space

Test

To test this pull request, you can run the following commands:

cd pkg/core/config/
go test
cd ../../
go build -o bin/updatecli .
./bin/updatecli diff --config e2e/updatecli.d/success.d/npm.jso

Additional Information

Tradeoff

/

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
JSON is a subset of YAML...
@olblak olblak added the enhancement New feature or request label Aug 10, 2023
@olblak olblak added this to the 0.57.0 milestone Aug 10, 2023
@dduportal
Copy link
Contributor

As long as JSON does not replace YAML, it looks ok 👍

@olblak
Copy link
Member Author

olblak commented Aug 10, 2023

As long as JSON does not replace YAML, it looks ok 👍

Hoooo no, I am not going to write Json

@olblak olblak merged commit 25d4c03 into updatecli:main Aug 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants