Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Image Tag to Docker Image Digest #1464

Merged
merged 8 commits into from
Aug 12, 2023
Merged

Conversation

olblak
Copy link
Member

@olblak olblak commented Aug 11, 2023

Fix #999

I had the param hidetag to hide the tag from the final digest such as

sources:
  ghcr.io:
    name: "Get Latest Tag from ghcr"
    kind: "dockerdigest"
    spec:
      image: "ghcr.io/updatecli/updatecli"
      architecture: "amd64"
      tag: "v0.35.1"
      hidetag: true

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/dockerdigest/
go test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the resource-dockerdigest Resource of kind dockerDigest label Aug 11, 2023
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the enhancement New feature or request label Aug 11, 2023
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@dduportal
Copy link
Contributor

Nit picking a bit but i would expect a verb in its present form: « hidetag »

otherwise LGTM !

@olblak
Copy link
Member Author

olblak commented Aug 12, 2023

Nit picking a bit but i would expect a verb in its present form: « hidetag »

otherwise LGTM !

Haha my last commit moved frome hidetag to hiddentag , happy to revert

@olblak
Copy link
Member Author

olblak commented Aug 12, 2023

Voila just revert the last commit to go back to hidetag

@olblak
Copy link
Member Author

olblak commented Aug 12, 2023

Example of the e2e execution where ghcr.io uses hidetag while dockerhub do not

###########################################
# RETRIEVE THE LATEST DOCKER IMAGE DIGEST #
###########################################


SOURCES
=======

dockerhub
---------
✔ Docker Image Tag updatecli/updatecli:v0.35.1 resolved to digest index.docker.io/updatecli/updatecli:v0.35.1@sha256:5d86b9249e62a10655a207359cf8480e113284d4bcfd68cd088de5879e293408

ghcr.io
-------
✔ Docker Image Tag ghcr.io/updatecli/updatecli:v0.35.1 resolved to digest ghcr.io/updatecli/updatecli@sha256:5d86b9249e62a10655a207359cf8480e113284d4bcfd68cd088de5879e293408


@olblak olblak merged commit eb89bef into updatecli:main Aug 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resource-dockerdigest Resource of kind dockerDigest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Docker Image Tag to Docker Image Digest
2 participants