chore: add error handling around reported areas from golangci-lint #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\o/ Thanks for this |
olblak
reviewed
Jan 25, 2021
| tmp.Clean() | ||
| return err | ||
| err = tmp.Clean() | ||
| return |
There was a problem hiding this comment.
That's interesting that you use the implicit return, without specifying return err
olblak
reviewed
Jan 25, 2021
| @@ -42,13 +42,6 @@ func (g *Github) Changelog(name string) (string, error) { | |||
|
|
|||
| client := g.NewClient() | |||
|
|
|||
| type release struct { | |||
There was a problem hiding this comment.
I have to double check because I think it's needed for the gaphql calll
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
|
I have to slightly modify your PR, initially I wasn't correctly handling Dockerhub response and with your PR, it correctly fail :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.