-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: HelmChart always bumps Chart Version #1541
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
This commit refactors the helm chart plugin to use the version from the origin branch when used with a scm Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
* Update appVersion before updating chart version * Only force updating Chart version update scm is specified otherwise only bump the version when the chart changed either appVersion or its content Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
* Rename workingChartMetadata to currentChartMetadata for better visibility Signed-off-by: Olblak <me@olblak.com>
olblak
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Sep 7, 2023
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #693
\When used with a scm, the helmchart resource now monitors the Chart.yaml from the branch mentioned by the scm resource. It tries to be smart by either using the computed version from the base branch, or it uses without modification the one mentioned in the new temporary branch if the later one is newer.
Test Scenario
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement
Chart.yaml
and don't try to handleChart.yml
which I think is an accepted file extension.