fix: ensure docker image checks architecture

[mcwarman]

Fix #1582

Moved away from setting remoteOptions for single architecture, as this was causing the multi conditions case to fail.

I can remove the tests if we don't want it to look up those images.

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/dockerimage
go test

Additional Information

Potential improvement

Mock the tests

[olblak]

Thanks for looking into this issue, my understanding is they are still images out there that uses the old schema so we may need to disable the architecture support if architecture/architectures is unset. like before your fix :p

[mcwarman]

I think the fix does potentially deal with that scenario, unless I've misunderstood what you are saying:

• New default to be empty list of achitectures
• on source if list is empty parse empty string to checkImages, else take the first in the list. source.go#L51-L60
• on condtions if list is empty parse empty string to checkImages, else iterate over architectures condition.go#L26-L42
• in checkImage then deals with empty arch by not checking it, if it is provided and its unsupported only return an error then.
  • main.go#L102-L104
  • main.go#L118-L136

[dduportal]

I think the fix does potentially deal with that scenario, unless I've misunderstood what you are saying:

* New default to be empty list of achitectures

* on `source` if list is empty parse empty string to checkImages, else take the first in the list. [source.go#L51-L60](https://github.com/mcwarman/updatecli/blob/fix/docker-images-check-arch/pkg/plugins/resources/dockerimage/source.go#L51-L60)

* on `condtions` if list is empty parse empty string to checkImages, else iterate over architectures [condition.go#L26-L42](https://github.com/mcwarman/updatecli/blob/fix/docker-images-check-arch/pkg/plugins/resources/dockerimage/condition.go#L26-L42)

* in `checkImage` then deals with empty arch by not checking it, if it is provided and its unsupported only return an error then.
  
  * [main.go#L102-L104](https://github.com/mcwarman/updatecli/blob/fix/docker-images-check-arch/pkg/plugins/resources/dockerimage/main.go#L102-L104)
  * [main.go#L118-L136](https://github.com/mcwarman/updatecli/blob/fix/docker-images-check-arch/pkg/plugins/resources/dockerimage/main.go#L118-L136)

That looks a sane set of code paths 👍 Thanks for looking into it!

[olblak]

Thanks for the explanation.
I just did some testing, and I really like how you nicely solve the problem

[olblak]

@mcwarman Great PR