Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set json resource result #1592

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Correctly set json resource result #1592

merged 6 commits into from
Sep 13, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Sep 13, 2023

Fix #1590

Test

To test this pull request, you can run the following commands:

go build -o bin/updatecli
./bin/updatecli diff --config e2e/updatecli.d/success.d/json.yaml

Additional Information

Tradeoff

Potential improvement

  • improve json spec comments
  • source display full path file while condition and target shows the relative file path

@olblak
Correctly set json resource result
f5a7b4f 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added bug Something isn't working resource-json labels Sep 13, 2023
@olblak olblak merged commit 6f7ddb9 into updatecli:main Sep 13, 2023
6 checks passed
@olblak olblak deleted the issue/1590 branch October 17, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working resource-json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON target does not update values
1 participant
@olblak