-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to share/reuse Updatecli manifest using any OCI registry #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
allow to specify multiple config Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Well the oras library is bumped with the Helm dependency update in #1626 |
olblak
changed the title
Allow to share/reuse Updatecli manifest to/from OCI registry
Allow to share/reuse Updatecli manifest using any OCI registry
Oct 1, 2023
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
fix minor displaying issue Use the correct image tag Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1600
TODO
This pullrequest allows to:
A policy can be composed of manifest, values, and secrets files
values and secret files can be overridden at runtime similarly the current behavior
when we specify multiple
--values
or--secrets
I also did a few code cleanup:
oras-project/oras-go
to1.2.4
. This dependency was needed for go-container-test and several other dependency in the container space like moby or helm. It potentially introduces a breaking change for older version of those dependencies. I had a quick look and it shouldn't affect the code we use. This version bump will also unblock PR like Update Golang module github.com/moby/buildkit #1578Test
To test this pull request, you can run the following commands:
go build -o bin/updatecli ./bin/updatecli manifest push --config updatecli/updatecli.d/updatecli.yaml -t ghcr.io/olblak/policies/updatecli:latest . ./bin/updatecli manifest pull --disable-tls localhost:5000/myrepo:latest ./bin/updatecli manifest show --disable-tls ghcr.io/olblak/policies/updatecli:latest ./bin/updatecli diff --disable-tls ghcr.io/olblak/policies/updatecli:latest
Additional Information
This feature relies on the
docker login
to create the credential store, updatecli doesn't provide login mechanismSecret or Values files specified at command execution will override default values publish on the registry.
Similar to doing
updatecli diff --config manifest.yaml --values default.yaml --values override.yaml
File are not merged using deep merged
Tradeoff
Potential improvement
while looking at the cmd package, I realize how none consistent the command and I wonder if
updatecli diff
should becomeupdatecli pipeline diff
updatecli apply
should becomeupdatecli pipeline apply
or rename
updatecli diff
should becomeupdatecli policy diff
updatecli apply
should becomeupdatecli policy apply