Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dockerimage correctly set auth if arch unspecified #1615

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Sep 24, 2023

Fix #1613

The authentication options weren't defined if the plugin was used without specifying the architecture in the setting which is solved with the current pullrequest.

I tested this PR using

sources:
  default:
    kind: dockerimage
    spec:
      image: ghcr.io/olblak/charts/upgrade-responder

conditions:
  default:
    kind: dockerimage
    spec:
      image: ghcr.io/olblak/charts/upgrade-responder
      tag: v0.1.5

which is a private docker image

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/dockerimage/
go test

Additional Information

Tradeoff

/

Potential improvement

/

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added bug Something isn't working resource-docker Resource of kind Docker Image labels Sep 24, 2023
@olblak olblak merged commit f8708da into updatecli:main Sep 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resource-docker Resource of kind Docker Image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"dockerimage": unauthorized as of v0.60.0
1 participant