Run helm chart metadata update only on a changed target #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
dduportal
changed the title
Signed-off-by: Olblak <me@olblak.com>
|
Thanks I slightly changed the PR to also update the appVersion field update even if the target didn't change. |
I'm not sure to understand the use case (but I don't use updatecli to track appversion so I guess it should be fine?). Currently trying a local build of 3c9e749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1614
We only want to update the Chart metadata if the chart has been modified during the current target execution.
To make this process more idempotent in the context of a SCM, we could also check if the helm chart
has been modified during one of the previous target execution by comparing the current chart versus the one defined
on the source branch. But the code complexity induced by this check is probably not worth the effort today.
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement