Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Handle errors #163

Merged
merged 5 commits into from
Jan 28, 2021
Merged

Better Handle errors #163

merged 5 commits into from
Jan 28, 2021

Conversation

olblak
Copy link
Member

@olblak olblak commented Jan 28, 2021

Now that better catch errors during run some of them prevent updatecli to finish a run.
This PR handle some of them

  • Don't panic but return errors during config templating, we still want to apply valid update strategies
  • Don't exist if something went wrong during the prepare stage but instead try to apply strategies that can be apply

Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak changed the title Handling errors Better Handle errors Jan 28, 2021
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak added the bug Something isn't working label Jan 28, 2021
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak merged commit a32ab1b into main Jan 28, 2021
@olblak olblak deleted the handling_errors branch February 15, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant