Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various updatecli compose fixes #1705

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Conversation

olblak
Copy link
Member

@olblak olblak commented Oct 18, 2023

While working on https://github.com/olblak/updatecli-policy-docusaurus
I spotted a few issues which I am collecting and fixing in this pullrequest

  • fix: compose file should work without oci policies
  • fix: latest tag shouldn't return the oldest tag
  • fix: used sanitize policy version for before push to ensure that v prefix are removed
  • fix: various path scenarios when publishing policies

Test

To test this pull request, you can run the following commands:

cd <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak marked this pull request as draft October 18, 2023 18:15
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak marked this pull request as ready for review October 19, 2023 07:29
@olblak olblak added bug Something isn't working update-compose All things related to update compose labels Oct 19, 2023
@olblak olblak changed the title Share and Reuse cleanup various updatecli compose fixes Oct 19, 2023
@olblak olblak merged commit 50530fc into updatecli:main Oct 19, 2023
6 checks passed
@olblak olblak deleted the shareAndReuse/1 branch October 19, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working update-compose All things related to update compose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant