Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not exit on empty arguments #1707

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

kuisathaverat
Copy link
Contributor

Fix #1706

Compare the slice of arguments with an empty slice and a slice with one empty string. (credit @olblak)

Test

To test this pull request, you can run the following commands:

cat > test.yml << EOF
name: test
pipelineid: test

sources:
  one:
    name: 'Check {{ $updateChannel }} channel'
    kind: shell
    spec:
      command: echo 1
targets:
  one:
    name: 'Check {{ $updateChannel }} channel'
    kind: shell
    spec:
      command: echo 1
EOF
go run . apply "" --config test.yml

Additional Information

Tradeoff

Potential improvement

@olblak
Copy link
Member

olblak commented Oct 19, 2023

Thanks for the pullrquest, I am planning to trigger a release in the coming days as I made a few fixes around the registry

@olblak olblak added this to the 0.65.0 milestone Oct 19, 2023
@olblak olblak merged commit 5e78765 into updatecli:main Oct 19, 2023
6 checks passed
@olblak olblak added the bug Something isn't working label Oct 19, 2023
@olblak olblak removed this from the 0.65.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regresion] 0.64 ask to enable experimental flag
2 participants