Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for pinning docker digests by image config #1712

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Oct 21, 2023

Fix #1603

updatecli.yaml
# To compare the following digests with 
# https://github.com/updatecli/updatecli/pkgs/container/updatecli/139180422?tag=v0.64.1

sources:
  noarch:
    name: "Get Digest for docker image updatecli/updatecli:v0.64.1"
    kind: "dockerdigest"
    spec:
      image: "ghcr.io/updatecli/updatecli"
      tag: "v0.64.1"

  amd64:
    name: "Get Digest for docker image updatecli/updatecli:v0.64.1"
    kind: "dockerdigest"
    spec:
      image: "ghcr.io/updatecli/updatecli"
      tag: "v0.64.1"
      architecture: amd64

  arm64:
    name: "Get Digest for docker image updatecli/updatecli:v0.64.1"
    kind: "dockerdigest"
    spec:
      image: "ghcr.io/updatecli/updatecli"
      tag: "v0.64.1"
      architecture: arm64

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/dockerdigest/ 
go test

Additional Information

Tradeoff

Potential improvement

olblak and others added 3 commits October 21, 2023 13:27
@olblak olblak merged commit b0a9057 into updatecli:main Oct 23, 2023
6 checks passed
@olblak olblak deleted the issue/1603 branch October 23, 2023 13:46
@olblak olblak added the enhancement New feature or request label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resource-dockerdigest Resource of kind dockerDigest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for pinning digests by image config
1 participant