Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dockerfile) support multiple files #1739

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

dduportal
Copy link
Contributor

This PR adds the support of multiple files for the resources of kind dockerfile (conditions and targets).

Use cases:

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/dockerfile
go test

Please note that a new e2e test as added for dockerfile which tests the current file (for non regression) and the new files.

I've tested this E2E test locally with a diff and an apply. The only untested part is when using with an SCM.

Additional Information

Tradeoff

Using autodiscovery would help, of course but we want to control the list of files for now.

Potential improvement

N.A.

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal added enhancement New feature or request target Related to updatecli target condition Modify condition resource resource-dockerfile Resource of kind Dockerfile labels Nov 4, 2023
@dduportal dduportal requested a review from olblak November 4, 2023 16:33
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pulllrequest, I just did some testing locally and it works great 🎆

@olblak olblak added this to the 0.66.0 milestone Nov 4, 2023
@olblak olblak merged commit 3363984 into updatecli:main Nov 4, 2023
6 checks passed
@dduportal dduportal deleted the feat/dockerfile/multiple-files branch November 5, 2023 10:16
@dduportal
Copy link
Contributor Author

Associated documentation PR: updatecli/website#1207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
condition Modify condition resource enhancement New feature or request resource-dockerfile Resource of kind Dockerfile target Related to updatecli target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants