feat(dockerfile) support multiple files #1739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support of multiple files for the resources of kind
dockerfile
(conditions and targets).Use cases:
spec: files
inconditions
ofkind:file
#1026.Test
To test this pull request, you can run the following commands:
Please note that a new e2e test as added for
dockerfile
which tests the currentfile
(for non regression) and the newfiles
.I've tested this E2E test locally with a
diff
and anapply
. The only untested part is when using with an SCM.Additional Information
Tradeoff
Using autodiscovery would help, of course but we want to control the list of files for now.
Potential improvement
N.A.