🔨 Improve build process: unifies go build commands, improve reliability of Make and Docker assets #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit unifies all the different `go build` commands to have a single source of truth. It utilizes the script `utils/build.sh` which keep the same default behavior (e.g. building all the OS+arch binaries). But now, you can customize the `GOOS`, `GOARCH` and `CUSTOM_BINARY` (e.g. destination for the binary) environment variables.⚠️ Please note that there are edge cases when defining `CUSTOM_BINARY` and multiple `GOOS` or `GOARCH`. Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
- Add a "help" target to list target (and description through comments) - Add target dependencies for the `docker.*` targets - Add required targets to .PHONY to avoid Make errors when directories or files with the same name exist Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Goals: - Ensure that the behavior stay the same over time - Avoid broken builds and scary warning messages in GitHub Actions Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
- Ignoring unecessary files from Docker's build context - Enabling Docker BuildKit Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
changed the title
olblak
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs aims at improving the build process with the following key points (each one is a separated commit to ease the review and can be eventually be removed):
go buildcommands into a single one. This avoid any future configuration shifts between developer's builds, CI builds and release builds.Makefileto ease the contribution experience (bugfixes around PHONY and missing dependencies + adding a help message)