feat(git): allow to decide if we want to fetch submodules or not

[mavimo]

Fix #1732

If will allow to define if the submodule need to be fetched or not when a repository is initialised.

Test

To test this pull request, you can run the following commands:

pushd pkg/plugins/scms
go test
popd

pushd pkg/plugins/utils/gitgeneric
go test
popd

Additional Information

Tradeoff

Potential improvement

[olblak]

Thanks @mavimo for opening this pullrequest.

I recently stumbled on this problem and I asked my self if it was needed and you confirm that it is.

[olblak]

Something worth mentioning, we always try to avoid breaking changes between Updatecli releases so something we use is the feature flag experimental like here

So if we need to introduce a breaking change, we gate it before the experimental flag for a few release while we communicate about it.

[mavimo]

@olblak I was thinking more to keep the current behaviour as default (aka by default is "true"), more than including a flag for that, whyt?
At the moment the only way to use this approach is to use a nullable pointer in the yaml unmarshaling (unless we include something like https://github.com/creasty/defaults ), not sure if we want to move on this direction (I push a change in the code here)

[olblak]

@olblak I was thinking more to keep the current behaviour as default (aka by default is "true"), more than including a flag for that, whyt? At the moment the only way to use this approach is to use a nullable pointer in the yaml unmarshaling (unless we include something like https://github.com/creasty/defaults ), not sure if we want to move on this direction (I push a change in the code here)

Great then, I didn't think about using a pointer to keep the current behavior :)

[olblak]

Nice pullrequest. It's really awesome the effort put on the testing.
I'll wait for the test to pass and merge unless something goes wrong

[olblak]

All things appears good, thanks for the pullrequest