Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(file): ignore searchpattern not found when used with matchpattern #1766

Merged
merged 3 commits into from
Nov 14, 2023
Merged

fix(file): ignore searchpattern not found when used with matchpattern #1766

merged 3 commits into from
Nov 14, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Nov 14, 2023

Fix #1765

Test

To test this pull request, you can run the following commands:

cd <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

@olblak
feat(file): Allow to ignore pattern not found
f0ada4c 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the resource-file Resource of kind File label Nov 14, 2023
@olblak
fix(file): remove unneeded setting ignorenotfound
9eacb62 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak changed the title feat(file): Allow to ignore pattern not found fix(file): ignore searchpattern not found when used with matchpattern Nov 14, 2023
@olblak olblak added the bug Something isn't working label Nov 14, 2023
@olblak olblak merged commit 991612c into updatecli:main Nov 14, 2023
6 checks passed
@olblak olblak deleted the issue/1765 branch November 14, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
bug Something isn't working resource-file Resource of kind File
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow to ignore File content pattern not found
2 participants
@olblak @dduportal