-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable GitHub Pull Request #177
Conversation
After a quick discussion with @dduportal, we concluded that we need a way to specify a pull request title as it's challenging to generate a title that totally represents changes done inside a pull request. Also In the current state, each target will update a PR title Another interrogation element that I had was, was it fine to automatically update a PR title/body when the content of the pull request evolves or if we need to track those evolutions, and we conclude that it wasn't the responsibility of updatecli to keep track of that. A pull request title/body must just reflect files changed. Previously, updatecli would open a pull request per change like
Now we would just change PR
|
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Add missing error handling Signed-off-by: Olivier Vernin <olivier@vernin.me>
Remove debugging message Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
77d5e45
to
9c78e1c
Compare
Introducing a new parameter 'PipelineID' which can be used to group targets into one Github Pull Request, by default the PipelineID value is set to a full configuration checksum (source + conditions + targets) but it could be used to chain target from different configuration files.
The default value of 'PipelineID' changes the default behavior. By default, every target using SCM will push to the same branch that ends up being the same pull request on Github. This will significantly reduce the number of Pull requests generated especially in the situation we bump multiple times a value and we are only interested in the latest version update.
Another significant change for temporary branches is to use the format
updatecli_<pipelineID>
instead ofupdatecli/<pipelineID>
, in the latter situation if the target git repository has already a branch name "updatecli" then it would fail.Starting from this PR, we constantly update Github Pull request title and body with the latest information.