chore: factorize condition result code out of resource plugins

[dduportal]

This PR factorizes condition result code out of resource plugins:

• Simplify code for plugins (easier for contributors to write/update resources as they have less things to handle and can focus on the resource code)
• Centralize result object configuration (we can now change resource condition behavior in the core without impacting resources)
• Separate condition result (true or false) from error (unexpected behavior such as network error)
• Introduces the following behavioral changes (side effects of the PR):
  • githubrelease condition returns false but no error anymore when no upstream errors are triggered, with the same textual output as before.
  • gittag condition returns false but no error anymore when no upstream errors are triggered, with the same textual output as before.
  • golang condition returns false but no error anymore when no upstream errors are triggered, with the same textual output as before
  • gomod condition returns false but no error anymore when no upstream errors are triggered, with the same textual output as before
  • gomodule condition returns false but no error anymore when no upstream errors are triggered, with the same textual output as before
  • (nit) Homogenize methods to return an error (error.new() vs. fmt.Errorf())
  • (cleanup) removing obsolete "ConditionFromScm" tests

Test

To test this pull request, you can run the following commands:

make test

Additional Information

• Unit test are not checking for the message returned by the Condition() function. It wasn't before this PR, so I chose to focus on the refactor to avoid too much changes in this PR

[mcwarman]

Going to continue to look more at the code as this is the sort of PR that takes multiple passes.

But I remember when I first looked to create a contribution I read this: https://github.com/updatecli/updatecli/blob/main/CONTRIBUTING.adoc#3-respect-the-contract

I realised it was out of date and moved on, in hind sight I should have looked to to update it. The whole page possibly needs a overhaul so might be out of scope for this change but contacts could be updated.

[dduportal]

Going to continue to look more at the code as this is the sort of PR that takes multiple passes.

But I remember when I first looked to create a contribution I read this: https://github.com/updatecli/updatecli/blob/main/CONTRIBUTING.adoc#3-respect-the-contract

I realised it was out of date and moved on, in hind sight I should have looked to to update it. The whole page possibly needs a overhaul so might be out of scope for this change but contacts could be updated.

Good point! I've tried to update a bit in 0d845e0, WDYT?

[olblak]

I made another pass and I catch a few additional things. It's nice to see a lot of go code being cleanup