feat(pipeline): add target config dependsonchange #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dependsonchange enables the mechanism to check if the dependant target(s) have made a change. If the dependant target(s) have not made a change the target will be skipped.
mcwarman
force-pushed
the
feature/dependsonchange
branch
from
e0130c6
to
8e945ae
Compare
olblak
approved these changes
Nov 27, 2023
olblak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependsonchangeenables the mechanism to check if the dependant target(s) have made a change. If the dependant target(s) have not made a change the target will be skipped.Test
To test this pull request, you can run the following commands:
go build -o ./bin/updatecli && ./bin/updatecli diff --config e2e/updatecli.d/success.d/command.yamlAdditional Information
Tradeoff
Only e2e tests
Potential improvement
There's no unit tests of
RunTargets, I might have a look at getting some in but wanted to get this up for review.