Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(yaml): Add file search pattern && fix multiple file condition #1786

Merged
merged 10 commits into from
Dec 1, 2023
Merged

feat(yaml): Add file search pattern && fix multiple file condition #1786

merged 10 commits into from
Dec 1, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Nov 29, 2023

This pullrequest add the search pattern support for the yaml plugin and fix the yaml multi file condition.

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/yaml/
go test .

Additional Information

Tradeoff

Potential improvement

@olblak
chore(yaml): reenable yaml e2e test
38eb6dc 
Signed-off-by: Olblak <me@olblak.com>
@olblak
feat(yaml): Add search pattern and fix multiple file condition
6f8a46f 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the resource-yaml Resource of kind YAML label Nov 29, 2023
@olblak olblak marked this pull request as draft November 29, 2023 20:18
@olblak
fix typos
e910a62 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak changed the title feat(yaml): Add search pattern && fix multiple file condition feat(yaml): Add file search pattern && fix multiple file condition Nov 30, 2023
@olblak
chore(yaml): more error to specific file
dcd75ad 
Signed-off-by: Olblak <me@olblak.com>
@olblak
chore(yaml): convert if to switch statement
51c22ba 
Signed-off-by: Olblak <me@olblak.com>
@olblak
chore(yaml): improve target description formatting
82692fb 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak marked this pull request as ready for review November 30, 2023 15:51
@olblak
fix(helm): fix helm target description
9ed48b9 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added this to the 0.68.0 milestone Nov 30, 2023
@olblak olblak merged commit 1a70710 into updatecli:main Dec 1, 2023
6 checks passed
@olblak olblak deleted the yamlSearchPattern branch December 4, 2023 09:16
@olblak olblak added the enhancement New feature or request label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal left review comments

Assignees
No one assigned
Labels
enhancement New feature or request resource-yaml Resource of kind YAML
Projects
None yet
Milestone
0.68.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olblak @dduportal