Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autodiscovery): move autodiscovery out of experimental #1814

Merged
merged 8 commits into from
Dec 8, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Dec 5, 2023

Fix #1396

Without being perfect, I think it's time to move autodiscovery out of experimental.
The core feature is out for a while, and improvement must be done per plugin

Test

End to end tests must pass

make build test-e2e 

At least autodiscovery tests must pass

Additional Information

Tradeoff

Potential improvement

@olblak olblak added enhancement New feature or request autodiscovery All things related to the autodiscovery feature labels Dec 5, 2023
@olblak olblak changed the title feat(autodiscovery): move autodiscovert out of experimental feat(autodiscovery): move autodiscovery out of experimental Dec 5, 2023
dduportal
dduportal previously approved these changes Dec 5, 2023
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@olblak
Copy link
Member Author

olblak commented Dec 5, 2023

I am wondering what's wrong with the e2e...
It's the first time I see this kind of issue and I can't replicate it locally 😞

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak enabled auto-merge (squash) December 8, 2023 10:32
@olblak olblak merged commit a247f39 into updatecli:main Dec 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery All things related to the autodiscovery feature enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Move autodiscovery out of experimental
2 participants