Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi sources support #183

Merged
merged 8 commits into from
Mar 15, 2021
Merged

Add multi sources support #183

merged 8 commits into from
Mar 15, 2021

Conversation

olblak
Copy link
Member

@olblak olblak commented Feb 20, 2021

This PR comes hand in hand with #181 to solve #158
While keeping backward compatibility, I am switching from one source to a map of sources.
Now for each condition/target, we must specify the sourceID parameter to specify which source a condition/target depends on,
it mainly used to get default values for those stages.

An example of this change

---
title: Bump jenkinsciinfra/helmfile image
sources:
  helm:
    name: Get Latest helm release version
    kind: githubRelease
    spec:
      owner: "helm"
      repository: "helm"
      token: {{ requiredEnv .github.token }}
      username: olblak
      version: latest
  helm2:
    name: Get Latest helm release version
    kind: githubRelease
    spec:
      owner: "helm"
      repository: "helm"
      token: {{ requiredEnv .github.token }}
      username: olblak
      version: latest
conditions:
  isENVSet:

@olblak olblak added the enhancement New feature or request label Feb 20, 2021
Add config update function

Fix config reset function

Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak
Copy link
Member Author

olblak commented Mar 14, 2021

I modified this PR to only focus on multi sources and remove any mention of more advanced templating.

Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak merged commit 817d532 into updatecli:main Mar 15, 2021
@olblak olblak deleted the multi_sources branch March 15, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant