Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scm): add BasicAuth to stash #1841

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

pismute
Copy link
Contributor

@pismute pismute commented Dec 12, 2023

PR plugins doesn't support BasicAuth even though Username is provided.

Test

I have no idea to test this module. I have tested manually over a bitbucket server.

Additional Information

Tradeoff

Potential improvement

add BasicAuth support to the other plugins

Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pullrequest, the change seems legit.
I'll trust you that it works as I don't have access to stash at the moment :D

@olblak olblak changed the title add BasicAuth to stash feat(scm): add BasicAuth to stash Dec 13, 2023
@olblak olblak added the enhancement New feature or request label Dec 13, 2023
@olblak olblak added this to the 0.70.0 milestone Dec 13, 2023
@olblak
Copy link
Member

olblak commented Dec 13, 2023

I am targeting an other release over the weekend or early next week

@olblak olblak merged commit 7ebb05d into updatecli:main Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants