Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Pull Request Format #185

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Update GitHub Pull Request Format #185

merged 2 commits into from
Mar 2, 2021

Conversation

olblak
Copy link
Member

@olblak olblak commented Mar 2, 2021

Fix #184

  • Display changelog as code block in github pull request
  • Use detail balise for changelog

Example: olblak/charts#73

Signed-off-by: Olivier Vernin olivier@vernin.me

Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak added the enhancement New feature or request label Mar 2, 2021
dduportal
dduportal previously approved these changes Mar 2, 2021
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

A minor (and non blocking) proposal (syntactic sugar, no functional change)

pkg/plugins/github/pullrequest.go Outdated Show resolved Hide resolved
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@olblak olblak merged commit 6ca8fab into updatecli:main Mar 2, 2021
@olblak olblak deleted the githubPR branch August 30, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not mention contributors
2 participants