feat: cache updatecli policies #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest add some basic caching by checking a policy directory already exist before pulling it from the registry.
Because the policy path contains the policy checksum which correspond to a version such as:
/tmp/updatecli/store/41c2af6a10da1f4b4b91717ebaa4659332dd3d7107919c494c71f1f618aeaad8/updatecli.dWe shouldn't have collision between the same policy with different version.
Test
I tested this pullrequest manually on github/website by running
../updatecli/bin/updatecli compose diff -f update-compose.yaml --experimental --debugAdditional Information
Tradeoff
Potential improvement
We could also have some caching based on the time such pull the policy if the local directory is older than one day but considering that policy path contains a checksum, I don't think it's really necessary