Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm autodiscovery should ignore subcharts #1877

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: helm autodiscovery should ignore subcharts #1877

merged 1 commit into from
Jan 18, 2024

Conversation

olblak
Copy link
Member

@olblak olblak commented Jan 18, 2024

Fix #1876

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/autodiscovery/helm/test/ 
go test

Additional Information

Tradeoff

Potential improvement

@olblak
fix: helm autodiscovery should ignore subcharts
f0af15d 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added autodiscovery All things related to the autodiscovery feature resource-helm labels Jan 18, 2024
@olblak olblak merged commit 100d4f7 into updatecli:main Jan 18, 2024
6 checks passed
@olblak olblak added the bug Something isn't working label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
autodiscovery All things related to the autodiscovery feature bug Something isn't working resource-helm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm autodiscovery fails with subcharts
1 participant
@olblak