Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: panic error in dockerimage resource #1889

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix: panic error in dockerimage resource #1889

merged 1 commit into from
Jan 24, 2024

Conversation

olblak
Copy link
Member

@olblak olblak commented Jan 23, 2024

Fix #1888

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/dockerimage/
go test

Additional Information

Tradeoff

Potential improvement

@olblak
fix: panic error in dockerimage resource
4d9e8a5 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added bug Something isn't working resource-docker Resource of kind Docker Image labels Jan 23, 2024
lemeurherve
lemeurherve approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@olblak olblak merged commit ab7b91f into updatecli:main Jan 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemeurherve lemeurherve lemeurherve approved these changes

Assignees
No one assigned
Labels
bug Something isn't working resource-docker Resource of kind Docker Image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic error with dockerimage source with tagfilter
2 participants
@olblak @lemeurherve