fix: json target when combined with scm #1890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #1590 (comment)
I discovered that the json target plugin combined with a scm was broken.
It's scenario difficult to test so I missed when for some reason the plugin stops returning the list of files to commit.
I also took the opportunity to apply the following improvement
Test
To test this pull request, I used the following manifest
and
go build -o bin/updatecli . ./bin/updatecli apply --config /tmp/updatecli.yaml --push=false
then I checked in
/tmp/updatecli/github/updatecli-test/kwctl/
that I had a commit with the file changedAdditional Information
Tradeoff
Potential improvement
While I am in this plugin, I need to double check the csv plugin and the toml one as they also rely on daselJust by looking at the code they seems to be fine